Printable View
I thought I would have a play with HTML5 this weekend, so installed the html5boilerplate extension.
http://cms-2.doublespark.eu/
I soon as I change my template to fe_html5_page.tpl I get this error in Firefox:
XML Parsing Error: syntax error
Location: http://cms-2.doublespark.eu/
Line Number 1, Column 1:<!doctype html>
^
Any ideas what the problem is?
:oops:
After I opened my eyes, I saw the "Document Type Definition" dropdown next to the "Page Template" dropdown in the layout.
Hi Gary,
according to this ticket #2799 I have checked your site with the W3C validator. Because of the conditional comments for the various Internet Explorer versions (added by the HTML5 extension) together with the Contao license comment you exceed the limit of 512 bytes, within the character encoding must be specified with.
Thanks xchs, after a a bit of playing around I fixed that error.
Cheers for pointing me in the right direction.
Still a couple of errors:
2 x "Bad value Content-Style-Type for attribute http-equiv on element meta."
Nothing I can do about those I guess.
And a couple that I need to tidy up in the calendar template.
Other than that looks like I'm ready to go with HTML5 :-)
Hmm, you removed Contao's license notice form the <head> section :shock:Quote:
Originally Posted by Doublespark
I guess it would be much better if the HTML5 boilerplate extension could handle the right classes for the <html> element already on the server side, instead of using five lines with IE conditional comments in the page template! Similar like the extension "browsercss" does provide it for the <body> element!
Well, unfortunately I do not know exactly what kind of meta attribute is used for http-equiv in HTML5.Quote:
Originally Posted by Doublespark
Thanks for pointing out the license notice.
I removed the <head> tag as it cured one of the validation errors, hadn't noticed that it removed the copyright :-(
Somehow I need to get the <meta charset="utf-8"> before the copyright notice.
I'll work it out.
xchs, I re-read your post :-)
I have deleted the conditional statements from the html5boilerpate template and implemented browsercss instead! (I was not aware of the extension, thanks for pointing it out).
After looking at this:
http://stackoverflow.com/questions/2025 ... ternal-css
I deleted the following 2 lines:
<meta http-equiv="content-style-type" content="text/css"/>
<meta http-equiv="Content-Script-Type" content="text/javascript"/>
That got rid of these validation errors, have not fully tested, but no immediate problems :-)
Thanks again.
Well, according to the information on Paul Irish's website he now recommends to put this IE specific classes to the <html> tag for the following reasons:Quote:
Originally Posted by Doublespark
However, since the extension "browsercss" provides the additional (browser) classes only for the <body> tag, we would have to adapt the PHP script "BrowserCSS.php" accordingly to match the <html> element (lines 154-173):Quote:
Here is the new recommendation, and the one that's in use in the HTML5 Boilerplate.
<html class="">
Why?
* This fixes a file blocking issue discovered by Stoyan Stefanov and Markus Leptien.
* It avoids an empty comment that also fixes the above issue.
* CMSes like WordPress and Drupal use the body class more heavily. This makes integrating there a touch simpler
* It doesn't validate in html4 but is fine in html5. Deal with it.
* It plays nicely with a technique to kick off your page-specific javascript based on your markup.
* It uses the same element as Modernizr (and Dojo). That feels nice.
[code=PHP:3cseftpf]<span class="syntaxdefault">
****public*function*insertInsertTag</span><span class="syntaxkeyword">(</span><span class="syntaxdefault">$strContent</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">*$strTemplate</span><span class="syntaxkeyword">)
</span><span class="syntaxdefault">****</span><span class="syntaxkeyword">{
</span><span class="syntaxdefault">********
********if</span><span class="syntaxkeyword">(</span><span class="syntaxdefault">strpos</span><span class="syntaxkeyword">(</span><span class="syntaxdefault">$strTemplate</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">*</span><span class="syntaxstring">'fe_'</span><span class="syntaxkeyword">)</span><span class="syntaxdefault">*</span><span class="syntaxkeyword">===</span><span class="syntaxdefault">*0</span><span class="syntaxkeyword">)
</span><span class="syntaxdefault">********</span><span class="syntaxkeyword">{
</span><span class="syntaxdefault">************
************if</span><span class="syntaxkeyword">(</span><span class="syntaxdefault">preg_match</span><span class="syntaxkeyword">(</span><span class="syntaxstring">"/<html[^>]*class[^>]*>/"</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">*$strContent</span><span class="syntaxkeyword">))
</span><span class="syntaxdefault">************</span><span class="syntaxkeyword">{
</span><span class="syntaxdefault">************** **return*preg_replace</span><span class="syntaxkeyword">(</span><span class="syntaxstring">'/<html*([^>]*)*class="([^"]+)"([^>]*)>/'</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">*</span><span class="syntaxstring">'<html*$1*class="$2*{{brow sercss}}"$3>'</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">*$strContent</span><span class="syntaxkeyword">);
</span><span class="syntaxdefault">************</span><span class="syntaxkeyword">}
</span><span class="syntaxdefault">************else
************</span><span class="syntaxkeyword">{
</span><span class="syntaxdefault">************** **return*preg_replace</span><span class="syntaxkeyword">(</span><span class="syntaxstring">'/<html*([^>]*)>/'</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">*</span><span class="syntaxstring">'<html*$1*class="{{browserc ss}}"$3>'</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">*$strContent</span><span class="syntaxkeyword">);
</span><span class="syntaxdefault">************</span><span class="syntaxkeyword">}
</span><span class="syntaxdefault">************
********</span><span class="syntaxkeyword">}
</span><span class="syntaxdefault">********
********return*$strContent</span><span class="syntaxkeyword">;
</span><span class="syntaxdefault">********
****</span><span class="syntaxkeyword">}
</span><span class="syntaxdefault">*</span>[/code:3cseftpf]
Please note that these changes are not update-safe!
Yes, I think you can delete these two lines, too. Especially if you provide for all the "stylesheet" and "javascript" <link> tags the correct type attribute accordingly.Quote:
Originally Posted by Doublespark
Comment #1:
Quote:
It's a waste of bandwidth. Nobody actually does anything with it. (It's so useless it isn't even included in HTML5.)
Your help and advice much appreciated xchs!
Maybe Jan will see this thread and consider amending browsercss, to either use or give the option to use the <html> tag.
Thanks again.
It's probably better if you create a new ticket (feature request) for it: http://www.contao-forge.org/projects/browsercss/issuesQuote:
Originally Posted by Doublespark
You're welcome.Quote:
Originally Posted by Doublespark
Hello,
I'm just working on a new version of browercss which should include your ticket.
I just don't get the point why you want the class in the HTML-Tag. In the Blogpost by Paul he just say that he want's to keep the BODY tag free for dynamic classes. But this works fine in Contao because we add these classes additionally.
I'd like to implement the method from Oliver to include the CSS class to optimize performance which can be found in this ticket (sorry, German ticket but I'm sure you'll understand the PHP code) which will only work for the BODY but not for the HTML tag.
Before implementing this, I need to know if there might be a reason to ass the classes to the HTML tag instead of the BODY tag which I don't see.
Thanks!
Jan
Hi Jan,
I have read in a few place that adding class to the html tag is preferable.
Here is an excerpt:
From: http://paulirish.com/2008/conditional-s ... r-neither/Quote:
2010.05.07: Patrick O'Neill put this technique on some steroids. I rather like it. See below:
<html>
Doug Avery of Viget points out he prefers to use this technique on the HTML tag, freeing the body tag for dynamic classes. That works just fine. I later changed all my sites to use it on HTML instead of body, actually… Also it combo's really well with the Avoiding the FOUC v3.0 technique as well as Modernizr.
You fancy something different?
2010.05.07: Oh sheesh ya'll. Mat Marquis pointed out the code would leave a page <body>-less in IE10, etc. (Well not really because IE would auto-construct a body tag, but anyway…) Some gt later and we're good.
2010.05.20: Turns out IE conditionals around css files for IE6 can slow down your page load time in IE8! Crazy, right? The solution here avoids that, as does forcing IE to edge rendering.
2010.06.08: And then… Rob Larsen points out that when these conditional classes are applied to the HTML element, it doesn't block. No empty comment necessary. I think that's a new winner.
Hi,
This is what I've written above. As Contao is very flexible here we can use the BODY tag for both: The browser classes and the dynamic classes.Quote:
Originally Posted by Doublespark
[/quote]Quote:
Originally Posted by Doublespark
As we don't use conditional comments in browsercss, nothing will block and we won't have empty comments.
If I understand this correct these arguments don't fit for browsercss extension. Correct?
Jan
Hi Jan,
I'm sure I read on html5boilerplate that there were good reasons for adding to html and not body. From memory it was that adding to body can cause strange bugs in some circumstances.
Vague I know.
I have tried searching http://html5boilerplate.com/ but can't find what I read. Maybe it's been updated and no longer considered an issue.
I did find this https://github.com/paulirish/html5-boil ... issues/378
Would that be an issue?Quote:
@MartinMa: I think a problem with (2) is that a lot of CMS add id/classes to the body tag, which would create a lot of duplication. Furthermore, it could create problems for people writing IE6-specific styles because the browser doesn't really support chains of classes, e.g., ie6.mybodyclass {}
http://mathiasbynens.be/notes/safe-css-hacks#comment-13Quote:
OK! @julienw seems correct, here's a basic testcase of what he is describing. It doesn't drop IE8 into IE7 mode. But other issues related to use on body remain.
Ex 1 : http://pastie.org/1926628
Switching the conditional comments back to the html element but leaving the empty conditional comment above the doctype also prevents IE8 from dropping into IE7 mode without needing the X-UA-Compatible header being set on the server-side.
Ex 2 : http://pastie.org/1926635
Jan - You know far more about this than me, go with whatever you think is best.
Either way, great extension - THANKS!
Hey,
I'm not sure. I don't support IE6 on my pages so I can't tell you if IE 6 has issues with the classes in the body tag. (I just give IE 6 users a special page telling them to update their browser.)
I will keep this ticket open but flag as "incomplete" to collect more arguments.
Jan
I suggest reading this short article found on boilerplate:
http://weblogs.asp.net/dwahlin/archi...ilerplate.aspx