Some bugs with Slideshow2

[aharvie]

Hi there,

I'm not sure if the author of the Slideshow2 extension checks this forum, but I've been trying it out, and noticed a couple of things:

1. Image sizing doesn't seem to work properly for portrait-oriented images, it shows them zoomed-in and cropped. I fixed this by adding:

resize: "length"

To the options list in the Slideshow constructor in slideshow2_js_standart.tpl

2. If the options are set as:
Activate controls: no
Autoplay deactivated: yes

And "Full-size view" is checked on any of the images in the slideshow, then clicking that image will show the lightbox, but will also start the slideshow playing. Since the controls are deactivated (I wanted only manual control via the thumbnails), there's no way to stop/pause it again. This can be fixed by changing line 23 of the same JS template:

onClose': function(){ this.pause(false); }.bind(show_<?php echo $this->id; ?>),

Setting 'false' to 'true'. However, for it to work with all cases, this should probably be set by the module (i.e. if no controls, set to to autoplay state.)

Great extension, keep up the good work!

[schlauchbagmachine]

Hi aharvie,

i was not checking when you posted your message but im now following.

I think this error should be fixed with the latest version.
If not please tell me.

Greetings Sabri